search

mocha-parallel / mocha-parallel-tests

Parallel test runner for mocha tests. Looking for maintainer.
MIT License
200 stars 45 forks source link

tslib is required but missing from dependencies #262

Closed countergram closed 5 years ago

countergram commented 5 years ago

tslib is required in multiple places in the distributed version of this library, including the CLI, so it should be a dependency. Currently it's not a dependency but mocha-parallel-tests can't be run without it.

1999 commented 5 years ago

Thanks for reporting this. Could you provide an example which file complains of missing tslib?

fab1o commented 5 years ago

I'm also encountering this issue Cannot find module 'tslib' when running it via command line.

This fixes it:

npm i -D tslib

but we should not have to do this

countergram commented 5 years ago

It's put into most/all the files by the build process.

npm i mocha-parallel-tests
grep -rl tslib node_modules/mocha-parallel-tests
node_modules/mocha-parallel-tests/dist/bin/options/reporter.js
node_modules/mocha-parallel-tests/dist/bin/cli.js
node_modules/mocha-parallel-tests/dist/subprocess/reporter.js
node_modules/mocha-parallel-tests/dist/subprocess/runner.js
node_modules/mocha-parallel-tests/dist/subprocess/cli.js
node_modules/mocha-parallel-tests/dist/main/runner.js
node_modules/mocha-parallel-tests/dist/main/thread.js
node_modules/mocha-parallel-tests/dist/main/task-manager.js
node_modules/mocha-parallel-tests/dist/main/mocha.js
1999 commented 5 years ago

Thanks again @countergram, version 2.2.2 should contain the fix.