search

mocha-parallel / mocha-parallel-tests

Parallel test runner for mocha tests. Looking for maintainer.
MIT License
200 stars 45 forks source link

fix #265: Using worker threads causes some native modules to crash #283

Closed slava-t closed 4 years ago

slava-t commented 4 years ago

This is a fix for 265. I already use these changes in one of the projects and it works.

slava-t commented 4 years ago

done

slava-t commented 4 years ago

Do you mean that I should write a test which succeed when a feature in the product is broken? I created the test first and ran it without that flag and it failed. Adding that flag makes the test succeed. The test case should test an expected behaviour of the product. Failing when requiring a native module in the test is not an expected behaviour.