mochajs / mocha

☕️ simple, flexible, fun javascript test framework for node.js & the browser
https://mochajs.org
MIT License
22.53k stars 3k forks source link

Website HTML tweaks #3783

Closed plroebuck closed 5 years ago

plroebuck commented 5 years ago

Description

"docs/_includes/default.html"

<a href="https://apex.sh/ping/" rel="external noopener" target="_blank">

Discussion

CDNRae commented 5 years ago

Hi! I'd like to tackle this issue if that's okay!

XhmikosR commented 5 years ago

I'd add https://validator.w3.org/nu/?doc=https%3A%2F%2Fmochajs.org%2F and also do some HTML5 hygiene like removing the useless end tags (/> -> >).

Finally, I'd stop inlining the SVGs. Since the website is behind Netlify, it has http/2 so this is not really needed. The current HTML size is 118.9KB after brotli compression, which is way too much.

On the other hand, I'd inline avatars.js before the closingbody` tag.

I could have a look, as long as I figure out how local development works :)

XhmikosR commented 5 years ago

OK, I sorted everything out, found an issue when building the docs on Windows too, so I'm gonna submit a few patches.

For the inlining part, I believe it's Netlify's image optimization setting? Or is it something in eleventy?