Closed plroebuck closed 5 years ago
Hi! I'd like to tackle this issue if that's okay!
I'd add https://validator.w3.org/nu/?doc=https%3A%2F%2Fmochajs.org%2F and also do some HTML5 hygiene like removing the useless end tags (/>
-> >
).
Finally, I'd stop inlining the SVGs. Since the website is behind Netlify, it has http/2 so this is not really needed. The current HTML size is 118.9KB after brotli compression, which is way too much.
On the other hand, I'd inline avatars.js before the closing
body` tag.
I could have a look, as long as I figure out how local development works :)
OK, I sorted everything out, found an issue when building the docs on Windows too, so I'm gonna submit a few patches.
For the inlining part, I believe it's Netlify's image optimization setting? Or is it something in eleventy?
Description
"docs/_includes/default.html"
Fix
<title>
(solution courtesy of @XhmikosR)Remove the
shortcut
relationship. While allowed, it's meaningless. See here also.Mocha logo
alt
attribute to "Mocha logo"id
attribute.width
andheight
attributes to stylesheet"docs/css/style.css"
Convert the
<span>
tag to a<div>
. Inline tags may not contain block tags.Add "rel=home" protocol for Mocha URL. Append slash ("/") to end of URL.
Use "https" protocol for CC license
<a>
"href" URLConvert the
<p>/<em>
tags with the following<dl>
embedding<time>
"docs/css/style.css"
Annotate all links to outside URLs with these relations:
external
- Indicate link is not part our websitenoopener
- SecurityDiscussion
nofollow
- Indicate not an endorsement. See here also.favicon
-like icons for mobile browsers?