Open JoshuaKGoldberg opened 9 months ago
Hey @JoshuaKGoldberg, I've submitted a pull request for this. Any feedback is much appreciated!
Ah, thanks @CheadleCheadle - but this issue hasn't been marked as accepted 😦. We generally only accept feature-adding PRs for issues marked as status: accepting prs
. I filed this just a feature request, and am waiting the other maintainers to triage it.
We've been talking a bit on having a separate label to indicate "this is still in triage" for issues. I filed https://github.com/mochajs/mocha/issues/5092 to make it. Sorry that the docs aren't super clear on this yet!
Thanks @JoshuaKGoldberg for the clarification on the PR requirements. We'll put a pin in this one for now!
Feature Request Checklist
faq
label, but none matched my issue.Overview
Mocha right now adds standard test hooks to
globalThis
:after
,describe
,it
, and so on. But there's nothing indicating that it's specifically Mocha being run, and not some other test framework. Would it be reasonable to add some variable likemocha
to the global scope?With this global variable, testing utilities would be able to statically determine the test framework (Mocha) without being explicitly told it in their configuration. This can be useful for utilities that hook into framework-specific APIs.
Suggested Solution
Alternatives
A
process.env
would work on the CLI / in Node.js, but not in all browser environments.Adding some string to a pre-existing global like
after
might work too, but seems hacky. Right nowafter.toString()
comes out to"function (name, fn) {\n suites[0].afterAll(name, fn);\n }"
.Additional Info
See https://github.com/JoshuaKGoldberg/console-fail-test/issues/10: https://github.com/JoshuaKGoldberg/console-fail-test is a utility that runs during tests and uses the test framework's APIs to call testing hooks. It can sort of dynamically detect Mocha, but the implementation is brittle.