search

mochi-hpc / mochi-ssg

Scalable Service Groups (SSG), a group membership service for Mochi
Other
1 stars 1 forks source link

HAVE_MPI in ssg.h #2

Closed shanedsnyder closed 3 years ago

shanedsnyder commented 3 years ago

In GitLab by @mdorier on Jun 13, 2017, 09:10

In a code using SSG (branch ssg-interface-rewrite), one has to #define HAVE_MPI before calling #include to enable MPI, but that does not guaranty that SSG was actually compiled with MPI.

Solution: there should be an ssg-config.h generated from a ssg-config.h.in and installed along ssg.h. This file would #define SSG_HAVE_MPI (or not) depending on how SSG was configure. ssg.h should then #include and use #ifdef SSG_HAVE_MPI instead of HAVE_MPI.

shanedsnyder commented 3 years ago

In GitLab by @mdorier on Jun 13, 2017, 09:20

Note: I realize that there is already an ssg-config.h, but it's not installed along nor included by ssg.h.

shanedsnyder commented 3 years ago

In GitLab by @mdorier on Jun 13, 2017, 09:48

I have submitted a merge request to fix this issue.

shanedsnyder commented 3 years ago

In GitLab by @shanedsnyder on Jun 14, 2017, 08:43

This is fixed in commit 0c3e972a.

Now there is a separate header for MPI related stuff that has to be additionally included by SSG users who want the MPI bootstrapping routine.

shanedsnyder commented 3 years ago

In GitLab by @shanedsnyder on Jun 14, 2017, 08:43

closed