search

mochi-hpc / mochi-thallium

Thallium is a C++14 library wrapping Margo, Mercury, and Argobots and providing an object-oriented way to use these libraries.
https://mochi.readthedocs.io
Other
11 stars 5 forks source link

`margo_get_xstream_by_name` deprecated #15

Closed roblatham00 closed 1 year ago

roblatham00 commented 1 year ago

I am getting a bunch of warnings like this:

In file included from /home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium/endpoint.hpp:163,
                 from /home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium/bulk.hpp:365,
                 from /home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium.hpp:9,
                 from ../src/client/bv-client.cc:6:
/home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium/engine.hpp: In member function 'auto thallium::engine::xstreams() const':
/home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium/engine.hpp:868:14: warning: 'int margo_get_xstream_by_name(margo_instance_id, const char*, ABT_xstream_opaque**)' is deprecated: Use margo_find_xstream_by_name instead [-Wdeprecated-declarations]
  868 |             &margo_get_xstream_by_name,
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-margo-0.13.1-vq4qghsz7a4jbj7wzd2mbeadfdrqlysp/include/margo.h:23,
                 from /home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-thallium-0.11.1-aqj6g435chxwrdvvchjseaox66nw5h7a/include/thallium.hpp:4:
/home/robl/work/spack/opt/spack/linux-ubuntu22.10-icelake/gcc-12.2.0/mochi-margo-0.13.1-vq4qghsz7a4jbj7wzd2mbeadfdrqlysp/include/margo-config.h:411:5: note: declared here
  411 | int margo_get_xstream_by_name(margo_instance_id mid,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~

using margo-0.13.1

% spack find --loaded
==> In environment benvolio
==> Root specs
mochi-bedrock

==> Installed packages
-- linux-ubuntu22.10-icelake / gcc@12.2.0 -----------------------
argobots@1.1   automake@1.16.5                     cereal@1.3.2  fmt@10.0.0  json-c@0.16       libtool@2.4.6  mercury@2.2.0       mochi-bedrock@0.6.2  mochi-ssg@0.5.3        mpich@4.1a1           openssl@1.1.1t  pkgconf@1.9.5  tclap@1.2.2
autoconf@2.71  ca-certificates-mozilla@2023-01-10  cmake@3.22.1  gmake@4.3   libfabric@1.18.0  m4@1.4.18      mochi-abt-io@0.5.1  mochi-margo@0.13.1   mochi-thallium@0.11.1  nlohmann-json@3.11.2  perl@5.32.1     spdlog@1.11.0  zlib@1.2.13
==> 26 loaded packages
mdorier commented 1 year ago

Yep, thallium uses some deprecated margo API. I didn't want to update it too soon as it forces a version dependency, but I think it's time to do it.

mdorier commented 1 year ago

This is now fixed in main. I'm not making a release point yet, though.