mochi-mqtt / server

The fully compliant, embeddable high-performance Go MQTT v5 server for IoT, smarthome, and pubsub
MIT License
1.3k stars 223 forks source link

Developers (core) Team #317

Closed mochi-co closed 1 year ago

mochi-co commented 1 year ago

@werbenhu was able to show me how to actually add people to the organisation, which is something I had totally misunderstood and missed. This should be corrected now, so anyone who was formerly a collaborator should have received an invitation to join the organisation. This should provide you with elevated access permissions - use wisely 🙂

The new process flow will look a little something like this:

I'll leave this issue open for a little while so people can see it.

werbenhu commented 1 year ago

@mochi-co I think it's best to retain the merging rights for you alone. Only you can ensure the technical quality and possess the most comprehensive overall vision. The final code review must be done by you. What I meant earlier is that you don't need to grant any rights to the members; you just need to add them to the team. This can help build stronger cohesion among everyone.

mochi-co commented 1 year ago

@werbenhu You're not the only person to say this to me, so my guess is it would make everyone feel more comfortable. I've set everyone to triage role - which is read and some issue management capabilities. You'll have to advise me if it's not working as expected :)

mochi-co commented 1 year ago

@werbenhu @dgduncan I'm not sure this is working correctly, so any advice would be appreciated.

werbenhu commented 1 year ago

@mochi-co I still don't have the permission to edit the code when I review some code, which also means I don't have the permission to submit code to the forked branch.

mochi-co commented 1 year ago

@werbenhu I've given everyone write access again, but offset this by adding a new branch rule that restricts merging to admins, and I've set the number of required approvals to 6+. I have no idea if this will work though, as I can't see it from outside of my own account...

werbenhu commented 1 year ago

@mochi-co it works. I can now submit to the forked repository. Thanks.