search

mochi / egeoip

Erlang IP Geolocation module, currently supporting the MaxMind GeoLite City Database.
Other
95 stars 57 forks source link

added country database lookup #10

Closed maxlapshin closed 10 years ago

maxlapshin commented 11 years ago

added lookup in country database, so no it is possible to deploy software with 300KB database, not 30 MB.

twonds commented 11 years ago

This does not seem to be different from #9

Can you expand on why you need this feature? Also, tests would be nice.

maxlapshin commented 11 years ago

Well, you may not merge pull requests and you will end with a big and incosistent tree of useless forks.

This is required, because I don't want to deploy software with 30 megabytes of useless data. All erlyvideo package with whole erlang and its binaries takes 24 megabytes. And more 30 megabytes is city database.

etrepum commented 11 years ago

The code in this PR looks better than #9, so that one should probably be closed. Tests would make accepting this PR go more quickly.

maxlapshin commented 11 years ago

Got it.

maxlapshin commented 11 years ago

Tests are added.

etrepum commented 10 years ago

It looks like this PR needs to be rebased, according to GitHub there are conflicts (I haven't reviewed the code yet)

maxlapshin commented 10 years ago

I have rebased commits.