some fixes from us at Klarna

mochi / egeoip

Erlang IP Geolocation module, currently supporting the MaxMind GeoLite City Database.

Other

95 stars 57 forks source link

some fixes from us at Klarna #5

Closed richcarl closed 13 years ago

etrepum commented 13 years ago

I like two of these three commits, the gitignore stuff is pointless because we already ignore /doc and /ebin and those directories are not in the tree. I don't think I can cherry-pick the good commits from github so I'll have to do it manually later.

richcarl commented 13 years ago

Thanks.

Btw., that doc dir of yours is missing an "overview.edoc", and the ebin dir is missing a .app file. ;-)

etrepum commented 13 years ago

There's an .app file in ebin after you run make, thanks to rebar.

overview.edoc is not something we currently use, we do our docs in another format internally and for open source stuff most of it is simply in the README. egeoip could use some more prose documentation, and that would be a good topic for another issue.