search

mochi / mochiweb

MochiWeb is an Erlang library for building lightweight HTTP servers.
Other
1.86k stars 474 forks source link

add support for SameSite=none in cookies #225

Closed djnym closed 5 years ago

djnym commented 5 years ago

Newer versions of the RFC6265BIS specify a value of "None" for SameSite in some cases.

djnym commented 5 years ago

@etrepum it would be really convenient for me if we could merge this and cut a tag with it, let me know your thoughts. Also, any reason not to switch over to rebar3 as the build system? And any reason not to use eunit macros in tests?

etrepum commented 5 years ago

I'd be happy to accept PRs to switch to rebar3 and/or refactor the tests to use eunit macros. The only reason it hasn't happened yet is that nobody has wanted it enough to contribute it!

etrepum commented 5 years ago

New tag is https://github.com/mochi/mochiweb/releases/tag/v2.20.0

djnym commented 5 years ago

@etrepum thanks for the quick tagging, saves me time down the line. I may see if I can't at least do the rebar3 bit soon as that feels worthwhile.