search

mochi / mochiweb

MochiWeb is an Erlang library for building lightweight HTTP servers.
Other
1.86k stars 474 forks source link

Start on rebar3 support #241

Closed etrepum closed 2 years ago

etrepum commented 2 years ago
nickva commented 2 years ago

Looking at make app templates, it seems rebar3 looks for templates in ~/.config/rebar3/templates/ as opposed to a sub-directory of the project. Do you think it is worth trying to get them to work (might have to add install_template / uninstall_template commands to cp and rm them from ~/.config/rebar3), or they are not used enough to justify the effort? Maybe just generate a few more example in ./examples instead?

Was also wondering if it makes sense not including a rebar executable and rely on the user's environment having one in the path. I had noticed that some projects like recon do that. For CI they use the official OTP docker images for various version which contain both rebar and rebar3 already

etrepum commented 2 years ago

I think removing the rebar binary is the way to go, and changing the README accordingly to make sure that dependency is clear.

Removing the template or telling people how to install it manually sounds fine, I don't think people are starting a lot of new projects with mochiweb these days.

nickva commented 2 years ago

@etrepum I gave it a try in https://github.com/mochi/mochiweb/pull/243