search

mochipon / pysesame3

Unofficial Python Library to communicate with SESAME 3 series products from CANDY HOUSE, Inc.
https://pysesame3.readthedocs.io/en/stable/
Other
22 stars 2 forks source link

Use official Web API to control SESAME devices #82

Closed mochipon closed 2 years ago

mochipon commented 2 years ago

I don't think I have received any official notification yet, but it seems that users are now charged to use the Web API from Candyhouse as pointed at https://github.com/mochipon/pysesame3/pull/79?w=1#issuecomment-1135619952 (comment).

We are now at a crossroads in the future direction of this project. and I hope that this project will not be harmful to everyone includes Candyhouse. Therefore, I have decided to remove some of the features already implemented.

That is, we choose to use only the official (i.e., paid) Web API to operate the device.

However, there is one critical feature missing here. We cannot get real-time notifications of status changes. We all know that Candyhouse has promised to provide some features (e.g., Webhook, IFTTT), but that promise has not been delivered for a long time. Therefore, this library will continue to provide the ability to connect to AWS IoT Core and receive real-time device state changes. This is the only feature that this library implements that is not officially provided.

codecov[bot] commented 2 years ago

Codecov Report

Merging #82 (690da5c) into main (8544c74) will decrease coverage by 0.46%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   93.07%   92.60%   -0.47%     
==========================================
  Files          10       10              
  Lines         635      622      -13     
==========================================
- Hits          591      576      -15     
- Misses         44       46       +2
Impacted Files Coverage Δ
pysesame3/const.py 100.00% <ø> (ø)
pysesame3/chsesamebot.py 84.14% <66.66%> (-0.67%) :arrow_down:
pysesame3/chsesame2.py 85.86% <83.33%> (-0.65%) :arrow_down:
pysesame3/auth.py 87.32% <100.00%> (-0.99%) :arrow_down:
pysesame3/cloud.py 88.04% <100.00%> (-1.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8544c74...690da5c. Read the comment docs.