search

mochixuan / react-native-smart-tip

🔥🔥🔥Toast , SnackBar , Modal , Show Toast above Modal
247 stars 37 forks source link

make react-native-root-siblings peerDependence #9

Closed taoqf closed 4 years ago

taoqf commented 5 years ago

see https://github.com/magicismight/react-native-root-siblings/issues/44

mochixuan commented 5 years ago

No problems found, can you talk about Chinese in general?

taoqf commented 5 years ago

@mochixuan react-native-root-siblings 存在一个全局的注册 https://github.com/magicismight/react-native-root-siblings/blob/master/index.js#L39 如果一个项目下存在多个版本的react-native-root-siblings,就会有问题.

mochixuan commented 5 years ago

哦，大致明白了，我现在换成了最新版的，应该没问题了吧

taoqf commented 5 years ago

但不是根本的解决办法,存在2种情况:

  1. 你这个库维护依赖跟不上react-native-root-siblings主版本号.
  2. 你不能排除别人不升级react-native-root-siblings,还使用1.x版本或是某个固定版本的情况.
mochixuan commented 4 years ago

好的，谢谢指点。