search

mock-foundation / moc

A (really) native and powerful macOS and iPadOS Telegram client, optimized for moderating large communities and personal use. Currently in alpha
GNU General Public License v3.0
119 stars 6 forks source link

Crash on text styling #179

Open EdisonJwa opened 1 year ago

EdisonJwa commented 1 year ago

I was trying to switch the folders and seems the moc is also fetching the data at this time. and then it crashed

version 0.3.0 (15)

The Problem report is as the following

Github reports body is too long and I'll put it in the following gist

https://gist.github.com/EdisonJwa/803c22aa179e978e668b29ee681fefb0

ggoraa commented 1 year ago

Well that looks interesting, it died on text styling, which should not die no matter what I saw a crash like this in AppCenter Crashes some time ago(smth like months) but was not able to reproduce it

EdisonJwa commented 1 year ago

Well that looks interesting, it died on text styling, which should not die no matter what I saw a crash like this in AppCenter Crashes some time ago(smth like months) but was not able to reproduce it

if so I'm considering the CJK(Chinese,Japanese, Korean) characters

ggoraa commented 1 year ago

The styling system should support UTF-8 fully, but thanks for clarifying!

EdisonJwa commented 1 year ago

The styling system should support UTF-8 fully, but thanks for clarifying!

Seems that the Korean characters will cause the problems While I'm opening my channel (which contains Korean characters) it crashed With the following problem report https://gist.github.com/EdisonJwa/6c64dea09ca85bfc970158418f98af83 (too large to embed)

and the channel for reproducing it https://t.me/+lcH67pJEr3IzNWY5 (for reproducing the crash)

EdisonJwa commented 1 year ago

And I'm not sure if the lag was also caused by CJK characters

ggoraa commented 1 year ago

@EdisonJwa what did you do exactly to trigger that crash? i can succesfully open that channel, and Moc doesn't die

ggoraa commented 1 year ago

@EdisonJwa No, lag is definitely not caused by CJK characters, it's a app-wide issue, because of poor optimization

EdisonJwa commented 1 year ago

@EdisonJwa what did you do exactly to trigger that crash? i can succesfully open that channel, and Moc doesn't die

Please check the video

https://user-images.githubusercontent.com/22003734/201721056-15e2a686-6143-47d9-9240-62788caa71db.mov

(Reuploaded)

the report with it https://gist.github.com/EdisonJwa/3b92e7a632256e570b3c1f74ccf8d71a

ggoraa commented 1 year ago

Hm You are on macOS Monterey, I am on Ventura, that's probably the reason why I can't reproduce it