mockingbirdnest / Principia

𝑛-Body and Extended Body Gravitation for Kerbal Space Program
MIT License
769 stars 69 forks source link

Remove the "Create Plan" button in the flight plan window #2277

Open SirMortimer opened 5 years ago

SirMortimer commented 5 years ago

When you click the "Flight Plan" button in the main window, you get the flight plan window with a single button in it that says "Create Plan" (not sure about the exact labels because i'm not currently looking at it). If there isn't a performance (or other) consideration barring it, I think that flight plan should be created as soon as the window opens to save that extra click.

Likewise, when you delete the last manœuvre and subsequently the flight plan, you should see a new (empty) plan instead of the "create" button.

pleroy commented 5 years ago

I am a bit unsure what you have in mind for the deletion path.

At the moment when the last manœuvre gets deleted, you are left with an empty flight plan and a "Delete flight plan" button. It would seem odd to keep this button: its only effect would be to delete/recreate the flight plan, effectively resetting its parameters to the defaults.

It seems to me that the "Delete flight plan" button should go away entirely, and that the flight plan should be deleted when (1) there are no manœuvres left and (2) the "Flight plan" window gets closed. That would be more consistent, I think, with the path where opening the "Flight plan" window creates an empty plan.

Of course, when there are manœuvres left, closing the "Flight plan" window should not have any effect on the plan itself. Maybe this should be reflected in the text of the button shown in the main window ("Create flight plan" vs. "Show flight plan" or some such).

What do you think?

SirMortimer commented 5 years ago

Resetting the plan whenever the last manœuvre is deleted might be inconvenient.

I have this bad habit that I seem unable to shake: when messing with flight plans, I sometimes get that orange message telling me that an integrator is unhappy with my lousy system performance and therefore I should increase steps or tolerance or CPU power or somesuch text (don't have the UI in front of me, so my recollection of that message is a bit foggy). Often I just start from scratch to reset everything to default settings, this to me this feels quicker and cleaner than fixing whatever parameters need to be fixed. It is usually at this point that I'll be angry at myself because now I have to dial up the flight plan prediction duration - again. I wouldn't want to force other users to experience that same anger.

Maybe just change the text on the delete button to "Reset Flight Plan" and do exactly that when it's pressed?

pleroy commented 5 years ago

I am fine with a "Reset" button, but I think we need a "Delete" (or "Hide"?) button too. There are times (e.g., warping over long distances) where you don't need a flight plan. It would be very weird if a plan was created the first time you open the "Flight plan" window and you could never get rid of it afterwards.

sthalik commented 4 years ago

It would be very weird if a plan was created the first time you open the "Flight plan" window and you could never get rid of it afterwards.

Please consider disabling the planning if only a single maneuver node exists, and it has zero delta-v. Furthermore, zero delta-v interacts badly with RemoteTech, resulting in the vessel spinning indefinitely in arbitrary directions.

Technically adding an empty node can be useful for Kerbal Alarm Clock, but then again the user can add a throwaway fractional delta-v amount.

SirMortimer commented 4 years ago

zero delta-v interacts badly with RemoteTech, resulting in the vessel spinning

If that is the case, this needs to be fixed by RemoteTech.