Appending before fork time

mockingbirdnest / Principia

𝑛-Body and Extended Body Gravitation for Kerbal Space Program

MIT License

771 stars 70 forks source link

Appending before fork time #2490

Closed barcharcraz closed 4 years ago

barcharcraz commented 4 years ago

Log file created at: 2020/03/12 09:09:17 Running on machine: DESKTOP-68GQI37 Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg @ 00007FFE864D6360 google::LogMessageFatal::~LogMessageFatal [0x00007FFE864D635F+47] @ 00007FFDF96788CC (No symbol) [0x00007FFDF96788CB] @ 00007FFDF984E857 principiaVesselVelocity [0x00007FFDF984E856+1276966] @ 00007FFDF984DF85 principiaVesselVelocity [0x00007FFDF984DF84+1274708] @ 00007FFDF97F00B5 principiaVesselVelocity [0x00007FFDF97F00B4+889988] @ 00007FFDF96E7998 principiaCatchUpLaggingVessels [0x00007FFDF96E7997+231] @ 00000203C9FFAA17 (No symbol) [0x00000203C9FFAA16] F0312 09:09:17.425650 28596 discrete_trajectory_body.hpp:170] Check failed: this->is_root() || time > this->Fork()->time Append at +6.25980497443201148e+03 s which is before fork time +6.26290882815326040e+03 s

I get these errors when seperating stages. I'm running quite a few mods which I understand could be an issue. Running Frenet on 1.8.1

pleroy commented 4 years ago

Could you please give us your save and your logs? See the FAQs for instructions.

barcharcraz commented 4 years ago

ERROR.20200312-093359.30344.log FATAL.20200312-093515.30344.log INFO.20200312-092649.30344.log WARNING.20200312-093359.30344.log KSP.log

barcharcraz commented 4 years ago

181real6.zip

barcharcraz commented 4 years ago

Would it be helpful to try using the latest version from master?

pleroy commented 4 years ago

For our information, the decoded stack:

https://github.com/mockingbirdnest/Principia/blob/f9d1326d0876eee1212c6ff0db0a98b628f46277/ksp_plugin/interface.cpp#L346-L351 https://github.com/mockingbirdnest/Principia/blob/f9d1326d0876eee1212c6ff0db0a98b628f46277/ksp_plugin/plugin.cpp#L749-L776 https://github.com/mockingbirdnest/Principia/blob/f9d1326d0876eee1212c6ff0db0a98b628f46277/ksp_plugin/vessel.cpp#L233-L243 https://github.com/mockingbirdnest/Principia/blob/f9d1326d0876eee1212c6ff0db0a98b628f46277/ksp_plugin/vessel.cpp#L579-L618 https://github.com/mockingbirdnest/Principia/blob/f9d1326d0876eee1212c6ff0db0a98b628f46277/physics/discrete_trajectory_body.hpp#L169-L170

pleroy commented 4 years ago

Would it be helpful to try using the latest version from master?

I don't think so. There has been no change in this code since Frenet that would cause the bug to magically go away.

barcharcraz commented 4 years ago

Interestingly this happened twice for me, so I suspect that some mod I'm running is making this bug much more likely.

pleroy commented 4 years ago

I have a hunch that some mod is creating parts out of step with the normal lifecycle of the game, and that this breaks one of our invariants. There are many messages like the following in your logs:

E0312 09:33:59.783618  5448 ksp_plugin_adapter.cs:966] Unpacked part mk1pod.v2 (7ACCEF60) appeared between BetterLateThanNever and WaitForFixedUpdate.  Linearly extrapolating its position at the previous frame.

At this point it would be useful to have a journal of the actions made by Principia. To do that, open Logging Settings in the main Principia window and select Record journal (starts on load) at the bottom left. Do a scene change to make sure that journaling is enabled (you should see Journaling is ON at the bottom right). Then try to reproduce the problem. If/when it fails again, send us the log files and the journal file found in your glog directory.

Journaling will make the game quite slow. Be sure to disable it once you've sent us the journal.

pleroy commented 4 years ago

Duplicate of #2507. Follow the music there.