mockingbirdnest / Principia

đť‘›-Body and Extended Body Gravitation for Kerbal Space Program
MIT License
755 stars 68 forks source link

Wild camera spin with mouse over of the Kerbal Konstructs Base Manager UI in the tracking station #3390

Closed Growflavor closed 2 years ago

Growflavor commented 2 years ago

Mouse over of the Kerbal Konstructs Base Manager UI (via Kerbin Side Remastered) in the tracking station results in wild camera spin as shown in this video:

https://youtu.be/bUjX9hdigaE

Please let me know if this is fixed on the Principia side or on the Kerbal Konstructs side.

My recollection is that other various UI windows also once caused the camera to spin wildly with Principia & were somehow fixed but I could only find the issue #2425.

Thanks!

eggrobin commented 2 years ago

This is a long-standing issue which has been reported about windows of multiple mods, and about the debug menu; until yesterday I did not have the faintest idea what was going on. Yesterday (well, today, I guess) while investigating the possibility scroll wheel interaction as part of #3382 I added the camera controls to Principia’s input locks (so that you don’t zoom the camera while scrolling over the Principia UI) and that led to the same problem.

It turns out that the camera rotation does not get updated when the camera controls are locked, so that we repeatedly apply our change of camera reference frame, leading to wild spin. This will be fixed in Hilbert.