search

mockingbirdnest / Principia

𝑛-Body and Extended Body Gravitation for Kerbal Space Program
MIT License
771 stars 70 forks source link

Make the maximal step count for the flight plan customizable #938

Closed eggrobin closed 8 years ago

eggrobin commented 8 years ago

Requested by Scott Manley.

eggrobin commented 8 years ago

We just want to make max_steps and possibly the tolerances customizable, not the integrator, thus FlightPlan will need a GetAdaptiveStepParameters and Ephemeris::AdaptiveStepParameters will need a set_max_steps. In addition, accessors (get_max_steps, get_length_integration_tolerance) will be needed to display the right numbers in the UI.

pleroy commented 8 years ago

We should have "plain old struct" representations of the ...StepParameters classes for interchange through the interface (this requires new protobufs).

eggrobin commented 8 years ago

Probably (although we probably don't want to pass the integrator choice through the interface yet, that's another kettle of fish), but frankly I'm not sure why Ephemeris::AdaptiveStepParameters can't be a struct (with public members) itself, since we're going to need to expose its members one way or another.

pleroy commented 8 years ago

Reassigning to @eggrobin for the UI part.