search

mockingbirdnest / Skopos

Σκοπός: KSP contracts that specify goals, and leave mission design to the player.
MIT License
2 stars 1 forks source link

Skopos ground stations have no atmosphere/pointing noise applied #15

Closed Capkirk123 closed 4 weeks ago

Capkirk123 commented 1 month ago

Partner issue to https://github.com/KSP-RO/RealAntennas/issues/38, as resolving it may demand changes from both mods

As shown in this screenshot of the connection debugger, no atmospheric noise is applied to receiving ground station, even with the antenna pointing a mere 0.9 degrees above the horizon.

Possibly related to https://github.com/KSP-RO/RealAntennas/issues/14, which also appears to stem from RealAntennas not quite realizing Skopos ground stations are ground stations and treating them as vessel antennas instead (vessel antennas do not have atmospheric noise calculations applied)

eggrobin commented 1 month ago

This needs an RA-side fix, https://github.com/KSP-RO/RealAntennas/issues/38#issuecomment-2294503134. It then needs a fix here, namely to give ground stations RACommNetHomes a ParentBody somehow. That should also fix https://github.com/mockingbirdnest/Skopos/issues/14.

eggrobin commented 4 weeks ago

It then needs a fix here

It turns out it doesn’t, they have a ParentBody already. Fixed by https://github.com/KSP-RO/RealAntennas/pull/42.