search

mockingbot / react-native-zip-archive

Zip archive utility for react-native
MIT License
420 stars 154 forks source link

chore(ios): Update SSZipArchive to 2.5.5 #303

Closed vomchik closed 4 months ago

vomchik commented 4 months ago

Fix for this issue

vomchik commented 4 months ago

@plrthink Hello. Could you take a look this PR?

plrthink commented 4 months ago

OK, would release this right now.

balmasich commented 4 months ago

@plrthink it's require minimum 15.5 deployment target

balmasich commented 4 months ago

https://github.com/ZipArchive/ZipArchive/blob/main/SSZipArchive.podspec#L10

vomchik commented 4 months ago

Damn, it looks like we need to revert it(

plrthink commented 4 months ago

@balmasich @vomchik Yes, I just found out that. Although it's a breaking change, I think we have to since it's needed for submitting to the app store.

plrthink commented 3 months ago

According to forks' feedback on this change, I just realized we should not update the deployment target internally, this makes many apps, that can't update the deployment target, unable to adapt the updates anymore.

Instead, we should let the developers do this themself.

So I just the v6.1.2, which reverted this PR. And if you're going to submit it to the app store, please follow the guide on the readme.

vomchik commented 3 months ago

@plrthink thank you!