search

mockito / mockito-kotlin

Using Mockito with Kotlin
MIT License
3.1k stars 200 forks source link

Update to Mockito 3 and bump major version #417

Closed TimvdLippe closed 3 years ago

TimvdLippe commented 3 years ago

Mockito 3 requires Java 8 minimum and the ArgumentMatchers reject null by default. Therefore, matchers will no longer work if null is passed in (which is better for Kotlin since Kotlin is non-nullable by default).

Supersedes and closes #387 Fixes #386 Fixes #364 Fixes #355

TimvdLippe commented 3 years ago

@mockitoguy I would like to merge this PR tomorrow (Monday the 29th) to also publish on social media, unless you have any objections?

mockitoguy commented 3 years ago

I would like to merge this PR tomorrow (Monday the 29th)

@TimvdLippe, ship it!

TimvdLippe commented 3 years ago

Tag pushed to https://github.com/mockito/mockito-kotlin/releases/tag/3.0.0

TimvdLippe commented 3 years ago

@mockitoguy I don't see a GitHub action build listed in https://github.com/mockito/mockito-kotlin/actions?query=event%3Apush I think we need to update our ci.yml to also run on tags. Does https://github.com/mockito/mockito-kotlin/pull/425 look good to you?