search

mockito / mockito-kotlin

Using Mockito with Kotlin
MIT License
3.1k stars 200 forks source link

migrate to JUnit5 #420

Open hennr opened 3 years ago

hennr commented 3 years ago

Not sure if you want to, but why not migrate to JUnit 5 I thought :)

TimvdLippe commented 3 years ago

Ideally I would like to do this when we switch over the main Mockito test suite (https://github.com/mockito/mockito/issues/1246) and I don't think we want to move to JUnit 5 just yet. Let's discuss further in the Mockito issue before we merge any PRs related to JUnit 5.

hennr commented 3 years ago

All right, no worries. If you need a helping hand on the other test code, let me know.

bohsen commented 3 years ago

@hennr Just curious. What are the advantages of using junit5 over junit4 (with respect to an updated junit dependency like junit 4.13.2)?

TimvdLippe commented 3 years ago

@bohsen That would be the same question for me, but let's move that discussion to the Mockito issue rather than this PR, so that we can keep this PR focused on the implementation. Thanks!

niki-belo-scacap commented 3 months ago

You folks might consider closing this one - it's been a while