search

mockito / mockito-kotlin

Using Mockito with Kotlin
MIT License
3.09k stars 198 forks source link

Run releases on Mockito-kotlin 4 #448

Closed TimvdLippe closed 2 years ago

TimvdLippe commented 2 years ago

Per https://github.com/mockito/mockito-kotlin/pull/447#issuecomment-940750432 the release on the previously published tag 4.0.0 didn't work, as it wasn't matching our release configuration.

frett commented 2 years ago

The release still didn't trigger because 4.x isn't included in the if condition for the deploy job: https://github.com/mockito/mockito-kotlin/blob/main/.github/workflows/ci.yml#L84

TimvdLippe commented 2 years ago

@frett mockito-kotlin 4.0.0 is available on Maven Central: https://repo1.maven.org/maven2/org/mockito/kotlin/mockito-kotlin/4.0.0/ published with https://github.com/mockito/mockito-kotlin/runs/3869921344 That's because the 4.0.0 tag was put on a commit on main.

frett commented 2 years ago

I was still using the old maven coordinates (com.nhaarman.mockitokotlin2:mockito-kotlin) which was the reason I couldn't find the 4.0.0 release 🤦