search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Hardcoded url to github #595

Closed jhoglin closed 6 years ago

jhoglin commented 6 years ago

There are hardcoded url to github.com. The setting conf.getGitHub().getUrl() should be used instead.

https://github.com/mockito/shipkit/blob/514ac7a43af0e3513a83f7518221086b203d4b45/subprojects/shipkit/src/main/groovy/org/shipkit/internal/gradle/notes/tasks/UpdateReleaseNotes.java#L53

https://github.com/mockito/shipkit/blob/514ac7a43af0e3513a83f7518221086b203d4b45/subprojects/shipkit/src/main/groovy/org/shipkit/internal/gradle/notes/tasks/UpdateReleaseNotes.java#L61

did take a quick look and didn't find any test that runs this code section so I didn't fix it in the current PR #594