search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Ignore test of default behaviour if env variable exists #600

Closed jhoglin closed 6 years ago

jhoglin commented 6 years ago

How about this solution to the problem with #594 @wwilk ?

Its not perfect to ignore test but as far as my abilities go right now its to much work to refactor so I can mock the EnvVariables class, which is the best way to go I believe.

About the existence of GH_WRITE_TOKEN is that present on all branches or just master or some such?

wwilk commented 6 years ago

Thanks you for working on this! As you said yourself it's not a perfect solution and @epeee suggested a more generic one, that can be used in more places, so we would probably go with it.

If you want to contribute by fixing any other issue I would be happy to help you with it! :)

wwilk commented 6 years ago

I'm not closing this one until https://github.com/mockito/shipkit/pull/601 is merged

jhoglin commented 6 years ago

Cool. Perfect that @epeee fixad that refactoring. Now it will be as it should be.

wwilk commented 6 years ago

Merged #601 so closing