search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Ignoring contributors #612

Closed micd closed 6 years ago

micd commented 6 years ago

Solution for issue #57 Added new configuration field and extended plugins to ignore contributors (or contributions done by contributors) defined in config.

Test I - release notes

  1. install new shipkit version
  2. call ./gradlew updateReleaseNotes- release notes should contain all contributors
  3. add team.ignoredContributors = ['shipkit-org'] to shipkit.gradle
  4. call ./gradlew updateReleaseNotes - release notes should not contain shipkit-org and its commits should not be included in the summary

Test II - contributors

  1. install new shipkit version
  2. call ./gradlew fetchContributors - all-contributors.json should contain all contributors
  3. add team.ignoredContributors = ['shipkit-org'] to shipkit.gradle
  4. call ./gradlew fetchContributors - all-contributors.json should not cointain shipkit-org user
micd commented 6 years ago

Thank you for quick review @wwilk. I would like to discuss one change that you have requested.

Could you address it, please?

micd commented 6 years ago

I have changed IgnoredContributor and definition of configuration a bit, because it turned out that login is not provided in Commit object.

Double check in IgnoredContributor#isTrue is mostly for users like 'shipkit-org', which has different commit's author name and contributor name.

wwilk commented 6 years ago

Thanks! Just two more things :)

micd commented 6 years ago

Thank you for collaboration!