mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Dependency parameter validation for tasks created in upgradeDependencyPlugin #620

Closed micd closed 6 years ago

micd commented 6 years ago

As described and discussed within #614. I have added lazy configuration to the tasks that depends on dependency parameter, which will validate if dependency exists.

Tests After running:

you should get GradleException with "Dependency property not set. You need to add 'dependency' parameter in order to run this task. E.g.: -Pdependency="org.shipkit:shipkit:1.2.3"message.

When -Pdependency parameter set there should not be such exception message.

wwilk commented 6 years ago

Please also describe briefly how this code was tested. It has to be unit tested too. The scenario of such test would be:

mockitoguy commented 6 years ago

Hey @micd, thank you for submission and sorry for lack of response. New Year's break caught us pretty busy :)

Can you rebase with master so that it merge cleanly?

Is it ok to review commit-by-commit? This PR contains many formatting changes so it would be useful to review commit-by-commit. This is only productive if your commits form a coherent history (e.g. no commits that revert previous commits, etc.).

mockitoguy commented 6 years ago

I'll take a stab at it tomorrow.

mockitoguy commented 6 years ago

Due to conflicts, I've opened a separate PR with @micd commits. Please review: #627

Thank for this contribution! We should be able to merge soon. Great error handling is very important for our library!