mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

mergePullRequest is not merging the pr due to 'No checks defined in pull request' #634

Closed epeee closed 6 years ago

epeee commented 6 years ago

After solving #629 we are still not able to automatically merge pr's.

[upgradeDownstream] [performVersionUpgrade] :mergePullRequest [upgradeDownstream] [performVersionUpgrade] [INCUBATING] merge pull requests is incubating and may change in any version. [upgradeDownstream] [performVersionUpgrade] Waiting for status of a pull request in repository 'mockito/shipkit' between base = 'master' and head = 'mockito:upgrade-shipkit-to-1.0.12'. [upgradeDownstream] [performVersionUpgrade] No checks defined in pull request https://api.github.com/repos/mockito/shipkit/pulls/633! Merge aborted.

see travis build log for details.

mockitoguy commented 6 years ago

Thank you for reporting! Do you want to take a stab at it?

epeee commented 6 years ago

yep, I will have a look at this one.

epeee commented 6 years ago

Doing one retry does the trick:

[upgradeDownstream] [performVersionUpgrade] Using /repos/mockito/shipkit/commits/85e6084f8097f321edceaeca5c86b28d4a60d20e/status for status check [upgradeDownstream] [performVersionUpgrade] All checks passed! Merging pull request in repository 'mockito/shipkit' between base = 'master' and head = 'mockito:upgrade-shipkit-to-2.0.2'.

let's close this one. There is still one problem remaining until we are able to automatically merge pr's. I will create a new issue.