search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Emit how long we have been waiting so far during github status checks #657

Closed epeee closed 6 years ago

epeee commented 6 years ago

As suggested by @mockitoguy during a review, let's emit how long we have been waiting so far in https://github.com/mockito/shipkit/blob/eb0cda01b2213bbd99abbba6f024a4f1062a49b6/subprojects/shipkit/src/main/groovy/org/shipkit/internal/util/GitHubStatusCheck.java#L37-L55 Currently, the log looks like https://travis-ci.org/mockito/shipkit/builds/348102705#L1106-L1137

micd commented 6 years ago

Hello @epeee!

How would you like the logs to look like?

epeee commented 6 years ago

Hi @micd, the log line should contain the current state, how long we have been waiting so far and how long we are going to wait now. The first and the last info is already available in the current log. Let's also add the 2nd one.

micd commented 6 years ago

@epeee thank you for clarification.

Could you provide information how can I test that with shipkit-example, please?

micd commented 6 years ago

Anybody, could you say how to test this? @mockitoguy ? @wwilk ?

wwilk commented 6 years ago

Hey @micd, sorry for the delay in response. You can test it by running "./gradlew performVersionUpgrade -Pdependency=org.shipkit:shipkit:5.6.7"

epeee commented 6 years ago

closing since this one is implemented now, thx @micd !