mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Publication(s) comparison doesn't handle dependency change only #679

Closed szpak closed 6 years ago

szpak commented 6 years ago

One commit in Mockito changed only the project dependencies. The corresponding Shipkit Travis build detected no changes in publications and the release hasn't been executed.

As a workaround the release has to forced manually.

epeee commented 6 years ago

Thx for reporting this one! I will have a look at it.

epeee commented 6 years ago

It looks like this one is already fixed in a newer version of shipkit (might be fixed by #619). I'm currently doing some local testing using a newer shipkit version and will provide a pr for updating shipkit in mockito project soon.

szpak commented 6 years ago

Thanks @epeee for taking care of that so quickly!

epeee commented 6 years ago

does work in shipkit 2.0.12, see

> Task :releaseNeeded 
  Commit message to inspect for keywords '[ci skip-release]' and '[ci skip-compare-publications]': <unknown commit message>
  Current branch 'release/2.x' matches 'release/.+': true

  Compared 4 publication(s). Changes since previous release:
  Differences between files:
  --- /home/ep/tmp/mockito/subprojects/junit-jupiter/build/previous-release-artifacts/junit-jupiter-2.17.0-sources.jar/META-INF/dependency-info.md
  +++ /home/ep/tmp/mockito/subprojects/junit-jupiter/build/libs/mockito-junit-jupiter-2.17.1-sources.jar/META-INF/dependency-info.md

    Here you can see the changes in declared runtime dependencies between versions.

    @@ -5,0 +5,1 @@
    + - org.junit.jupiter:junit-jupiter-engine:5.1.0
epeee commented 6 years ago

This one is fixed in Shipkit v2.0.7.

epeee commented 6 years ago

closing this one since mockito is using Shipkit v2.0.13 now.