mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Fixed problem with task cycle in Mockito #683

Closed mockitoguy closed 6 years ago

mockitoguy commented 6 years ago

I split the configuration into 2 separate actions, applied to ShipkitBintrayPlugin and JavaBintrayPlugin. This way, "org.shipkit.base" plugin should still work ok while we avoid regression seen in Mockito.

Fixes #680

Tested with Mockito, "testRelease" now works: https://gist.github.com/mockitoguy/363c115f3d46dffe1c5af2abb42d66d0

Sorry about introducing the issue. Many thanks to @epeee for identifying what PR broke Mockito!!!

Also disable Mockito project from downstream testing. It yields an awkward NPE: https://gist.github.com/shipkit-org/e8c882512c528dfa3c11646aca0fb482. I have not yet time to debug the NPE, however I tested the release with Mockito end-to-end and it works. Let's make progress and ship this PR.