search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Incubating warning opt out #722

Closed micd closed 6 years ago

micd commented 6 years ago

As suggested by @mockitoguy in #394. I have added logic to acknowledge incubating warnings. This will result in not printing such warning.

May be configured by:

shipkit { 
  incubatingWarnings.acknowlege = ['name', 'another name']
}
mockitoguy commented 6 years ago

Hey @micd!

Looking at all the complexity introduced, I think we should better "unincubate" the feature. This way, we get high quality new feature, and we don't have to add complexity to hide the warnings.

Sorry about the ticket and wasted effort on your side. Would you be willing to work together on a plan to get our incubating features promoted to a "release" state?

I like the code, though, implementation and tests are high quality!

micd commented 6 years ago

Hello @mockitoguy. Let's leave this PR.I agree that it's too much complexity just to hide warning.

Thanks for feedback.

Of course, I would like to contribute - it depends on my free time.

mockitoguy commented 6 years ago

Hey @micd, thank you for understanding!