search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

#75 Automatically update releases on GitHub #766

Closed mstachniuk closed 5 years ago

mstachniuk commented 5 years ago

Please review @epeee @mockitoguy

epeee commented 5 years ago

What about making new features like this one optional in the first place? Additionally, what do you think about extracting the "release notes update to github" to a separate plugin?

mstachniuk commented 5 years ago

In my opinion, there is no point to make it optional - a user doesn't need to configure anything, it's only added value. Also incubating fetures usually stay incubating very long (sometimes forever) what is not good for those features.

I thougt about separate plugin, it will be very simmilar to ReleaseNotesPlugin and needed to duplicate a lot of code. For compleatly new things, like https://github.com/mockito/shipkit/issues/233 I will create separate plugin.

Do you think it should be separated? We can discuss on our Slack. Thanks a lot for the review, better later then never :)