search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Bintray settings are not applied from shipkit.gradle #791

Open mockitoguy opened 5 years ago

mockitoguy commented 5 years ago

Standard way of configuring Bintray does not work in some projects. It seems like a bug in Gradle.

Typical content in "gradle/shipkit.gradle":

allprojects { 
   plugins.withId("com.shipkit.bintray") {
       bintray {
          ...
       }
   }
}

Problem is that bintray settings are not applied in some projects. For example, I needed this workaround: https://github.com/linkedin/dynamometer/pull/86

Given that we withId("...") cannot be trusted, perhaps we update the configuration along with the workaround above. Thoughts?

epeee commented 5 years ago

Hmm, that's interesting. I will try do dig into this one in the next days.

mstachniuk commented 5 years ago

I might be connected with Removal of deferred configuration behavior: https://docs.gradle.org/current/userguide/publishing_maven.html#publishing_maven:deferred_configuration

Prior to Gradle 5.0, the publishing {} block was (by default) implicitly treated as if all the logic inside it was executed after the project is evaluated. This behavior caused quite a bit of confusion and was deprecated in Gradle 4.8, because it was the only block that behaved that way.

I see the changes between Gradle 4.5 & 4.10.2 in last days: https://github.com/linkedin/dynamometer/commit/8f7efacc664f90001516a10a038c76dc630be152#diff-fd9d61e37d939c941e7a62077f38d62d

But I don't know how it's connected with Bintray plugin.