Closed mockitoguy closed 4 years ago
Merging #854 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #854 +/- ##
============================================
+ Coverage 76.85% 76.85% +<.01%
- Complexity 1229 1230 +1
============================================
Files 219 219
Lines 4467 4468 +1
Branches 334 335 +1
============================================
+ Hits 3433 3434 +1
Misses 922 922
Partials 112 112
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...rg/shipkit/internal/gradle/util/PomCustomizer.java | 75.8% <100%> (+0.39%) |
11 <0> (+1) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2ab193...80fa1ef. Read the comment docs.
Thank you for review!
Fixes #847 - users can configure pom in the build.file so our logic cannot blindly add XML nodes - we need to check for existence of nodes.
This is a wider problem - this PR fixes one instance - see the TODO in the code.
Happy New Year everybody :-)