Rename validatePlugins to validatePluginsSkipkit to avoid task name clash with Gradle 6.x

mockito / shipkit

Toolkit for shipping it used by Mockito library

http://shipkit.org

MIT License

158 stars 35 forks source link

Rename validatePlugins to validatePluginsSkipkit to avoid task name clash with Gradle 6.x #877

Open vlsi opened 4 years ago

vlsi commented 4 years ago

This fixes https://github.com/mockito/shipkit/issues/876 (GradlePortalReleasePlugin: Cannot add task 'validatePlugins' as a task with that name already exists)

vlsi commented 4 years ago

ShipkitJavaIntegTest fails with Gradle 6.5, and the cause seems to be tasks returned in the different order.

I don't know what does the test verify, so I don't know how to heal it.

@mockitoguy , can you please clarify?

Expected:

...
:api:generatePomFileForJavaLibraryPublication
:api:compileJava
:api:processResources
:api:classes
:api:jar
:api:javadoc
:api:javadocJar
...

Actual:

...
:api:compileJava
:api:processResources
:api:classes
:api:jar
:api:generateMetadataFileForJavaLibraryPublication
:api:generatePomFileForJavaLibraryPublication
...

vlsi commented 4 years ago

One of the workarounds could be "ignore :generatePom and :generateMetadata" tasks in skippedTaskPathsGradleBugWorkaround. The tasks do not seem to be important much, and they seem to be the only ones that produce unordered results.

WDYT?

mockitoguy commented 3 years ago

@vlsi, we are going to put the project in maintenance mode soon. The new plugins are:

Check out the new plugins. Would they work for you?