search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Include LICENSE to META-INF rather that to the root of the archives #878

Open vlsi opened 4 years ago

vlsi commented 4 years ago

https://github.com/mockito/shipkit/blob/fe138d17b136271584c85f058d78d7b410e33a7c/subprojects/shipkit/src/main/groovy/org/shipkit/internal/gradle/java/JavaLibraryPlugin.java#L42

LICENSE file at the root of the jar results in collisions when fat jar is generated (e.g. in case multiple dependencies have LICENSE at the top level).

META-INF/LICENSE is more-or-less standard location for the license.

An alternative option is to make license inclusion optional.

Note: different JAR files might need different licenses (e.g. regular and fat jar), so it is not right to put the same license file everywhere.

koral-- commented 4 years ago

Sounds good to me. Could you create a PR for that?

vlsi commented 4 years ago

Ah, I'm afraid I'm migrating off Shipkit as it does not support Gradle 6, and there are weird issues with licensing :-/

I have never used Shipkit (I've just forked a project that used Shipkit for release), and it takes me too much time to figure out the way to make it working :-(

Wish you all the best 🌞 , and I would tentatively refrain filing PRs to Shipkit so far.