search

mockko / livereload

LiveReload applies CSS/JS changes to Safari or Chrome w/o reloading the page (and autoreloads the page when HTML changes)
http://livereload.com/
1.18k stars 56 forks source link

Playframework SASS module support #74

Closed tonyxiao closed 13 years ago

tonyxiao commented 13 years ago

Added two lines to allow livereload to live reload changes from scss and ass files generated by playframework's sass module (http://www.playframework.org/modules/sass)

If there is no conflict this could be an interesting addition to people using playframework

NV commented 13 years ago

I don't quite understand the purpose of this change. Does browser still receive a plain CSS?

tonyxiao commented 13 years ago

Yea, browser still gets plain CSS . Server set up to compile scss before serving, just with different file extension

Tony Xiao Vision without execution is delusion.

On Mar 29, 2011, at 7:11 AM, NV reply@reply.github.com wrote:

I don't quite understand the purpose of this change. Does browser still receive plain CSS?

Reply to this email directly or view it on GitHub: https://github.com/mockko/livereload/pull/74#issuecomment-930505

NV commented 13 years ago

I get it now.

You edit some.scss file and LiveReload tells to the browser what "some.scss" is changed. Before your patch, LiveReload would reload the whole page. With your patch LiveReload reloads all stylesheets because "some.scss" won't match with "some.css".

Correct me if I'm wrong.

tonyxiao commented 13 years ago

Yep exactly. I could be wrong, but I think whenever you include .scss and .sass files as stylesheet links directly in html pages, it is implicit that the files are processed and parsed by the server before sending valid css, instead of SASS to the browsers.

That said this could be a rather specific feature of some web app frameworks / plugins, if you plan to keep livereload 100% "pure", it might make sense to leave things like this out. Though I'm not aware of any kind of conflicts with any other frameworks etc. as of now

On Mar 29, 2011, at 1:38 PM, NV wrote:

I get it now.

You edit some.scss file and LiveReload tells to the browser what "some.scss" is changed. Before your patch, LiveReload would reload the whole page. With your patch LiveReload reloads all stylesheets because "some.scss" won't match with "some.css".

Correct me if I'm wrong.

Reply to this email directly or view it on GitHub: https://github.com/mockko/livereload/pull/74#issuecomment-932108

NV commented 13 years ago

Merged 10 days ago. Closing.