mockturtl / cinnamon-weather

DEPRECATED. Use linuxmint/cinnamon-spices-applets instead.
https://cinnamon-spices.linuxmint.com/applets/view/17
28 stars 35 forks source link

In-panel font #110

Closed zagortenay333 closed 9 years ago

zagortenay333 commented 9 years ago

Not sure whether this is an issue with this applet or with something else, but I noticed that the font in the panel doesn't change from the default sans font. Here is another text applet next to it with the Droid sans font: screenshot from 2015-02-24 11 57 06

mockturtl commented 9 years ago

Not sure whether this is an issue with this applet or with something else

Please look into it and let me know.

zagortenay333 commented 9 years ago

From what I can see it's the applets fault. I didn't manage to find any selector that can modify it, and all themes have the same issue.

mockturtl commented 9 years ago

I'm afraid I don't know much about fonts. I can barely spot a difference between the letters "C" in your screencap.

How can I reproduce the problem?

screencap

mockturtl commented 9 years ago

I didn't manage to find any selector that can modify it,

$ git grep font
# stylesheet.css:14:  font-size: 35px;
# stylesheet.css:58:  font-size: 90%;
zagortenay333 commented 9 years ago

You are using the default theme; that one has the same sans font, so you can't see a difference. Try using one of my themes, which use the Droid Sans font.

I don't understand what that grep stuff is about. ._."

The only selector which right now has an effect on this is .applet-label, and I cannot change the font using it, only the color.

mockturtl commented 9 years ago

Try using one of my themes

With Numix-Cinnamon:

screencap2

What should I be looking at?

zagortenay333 commented 9 years ago

Hmm. Looking bit more closely, it seems that only the units "°C" ąnd "°F" are not the droid sans font. The number and conditions have the correct font. Also numix-cinnamon screenshot from 2015-02-27 18 19 05

Notice how in your screenshot the F from the unit is not the same as the F from "Feb". Then again, at least in your case the font did change between the two themes you showed. In my case it stays the same no matter what theme I use.

mockturtl commented 9 years ago

Eureka!

scap3

They are different characters, in fact: .

mockturtl commented 9 years ago

Then again, at least in your case the font did change between the two themes you showed. In my case it stays the same no matter what theme I use.

Which version of Cinnamon are you running? I'm on LMDE.

 $ cinnamon --version  # 2.0.14
zagortenay333 commented 9 years ago

I'm running 2.4.6.

Well, if it's a unicode character then that would explain it I guess. Is there any reason for that, or can it just be normal text?

mockturtl commented 9 years ago

Internationalization, I guess. It shouldn't translate the way a bare letter C/F would.

Maybe I'm not calling something I should be in 2.4 for a TextApplet to participate in system theming. I'll look into that.

Can you take a screenshot of your panel showing the weather applet's font mismatched beside, say, the calendar applet?

zagortenay333 commented 9 years ago

I wrote above that only the °C character appears to be mismatched because its a unicode character. The rest looks fine.

You are right though, didn't think that a C in this case shouldn't be translated. I guess it should be left as is then.

zagortenay333 commented 9 years ago

I guess this applet doesn't use a unicode character then: http://cinnamon-spices.linuxmint.com/applets/view/198

mockturtl commented 9 years ago

The rest looks fine.

Am I correct in understanding there is no problem here:

Then again, at least in your case the font did change between the two themes you showed. In my case it stays the same no matter what theme I use.

mockturtl commented 9 years ago

I guess this applet doesn't use a unicode character then

See here, if I'm not mistaken.

zagortenay333 commented 9 years ago

The weird thing is, you showed two screenshots there, one with then numix theme and one with the default theme, and the unicode °F did change as far as I can see. That doesn't happen on my machine. O_o

zagortenay333 commented 9 years ago

Hmm, if both these applets use a unicode characther, how come the C's look different in my screenshot at the top?

mockturtl commented 9 years ago

I see what you're telling me: the horizontal legs of the '℉' \u2109 are 1 vs. 2 pixels apart.

2.4, system default font applied to ℉ character 2.0, theme font correctly applied to ℉ character

Maybe it's a bug in 2.4?

mockturtl commented 9 years ago

if both these applets use a unicode characther, how come the C's look different

I meant that the source for the system-monitor applet uses the unicode degree character ° + bare letter C/F.

So they are different.

zagortenay333 commented 9 years ago

Yeah, I just figured that he only uses the ° unicode. I guess nothing can be done in that case.

Also, it seems that droid-sans doesn't support unicode, only droid sans fallback. That's why the °C is borrowed from the sans font in my themes.

mockturtl commented 9 years ago

droid-sans doesn't support unicode, only droid sans fallback

That's good to know. Thanks for reporting it.

zagortenay333 commented 9 years ago

I might actually open an issue on the other guys applet to ask whether he could use the '°C' unicode instead of only '°'