mockturtl / cinnamon-weather

DEPRECATED. Use linuxmint/cinnamon-spices-applets instead.
https://cinnamon-spices.linuxmint.com/applets/view/17
28 stars 35 forks source link

Fix applet.js to generate up to date .pot file #168

Closed ncelerier closed 7 years ago

ncelerier commented 8 years ago

Hello,

This is a pull request for a problem with pot file generation.

Without this pull request, if you update the pot file using this command: cinnamon-json-makepot --js po/weather@mockturtl.pot

You will see that the pot does not contain some strings anymore.

This is because cinnamon-json-makepot does not take into account string identifier between single quotes (e.g. _('Sunrise')) but only those between double quotes (e.g. _("Sunrise"));

I have updated applet.js to use double quotes when needed, and I have also updated the pot file to match the latest changes.

Can you have a look at this PR ?

Thanks.

mockturtl commented 7 years ago

Hello,

This issue is being closed because development is moving to linuxmint/cinnamon-spices/applets. Feel free to reopen your issue there.

Please see the release announcement here:

http://segfault.linuxmint.com/2017/01/changes-to-cinnamon-spices-for-developer-and-artists/