mockturtl / cinnamon-weather

DEPRECATED. Use linuxmint/cinnamon-spices-applets instead.
https://cinnamon-spices.linuxmint.com/applets/view/17
28 stars 35 forks source link

display error message on failure #85

Closed mockturtl closed 7 years ago

mockturtl commented 9 years ago

@crosser writes: https://github.com/mockturtl/cinnamon-weather/issues/49#issuecomment-61058048

when you specify a woeid that yahoo does not recognize, no useful diagnostic is produced, and the above errors are reported.

(And the page that opens on "Get WOEID" does not contain codes for my country.)

mockturtl commented 9 years ago

I agree the applet should be more informative when the API call fails. I'll look into what it sends back.

@crosser Where are you that has no WOEID codes? The applet only uses Yahoo's weather service; I hope to find time to add other data sources.

In the meantime, you might try the excellent bbcwx@oak-wood.co.uk desklet.

crosser commented 9 years ago

Yahoo has service for my location all right, with 5 day forecast too. It's Christopher's page that does not have a section for my country for some reason. Once I found my WOEID (RSXX0063) weather applet started to work.

mockturtl commented 9 years ago

@crosser I'm glad it's working for you. Thank you for the report.

mscheper commented 9 years ago

Until this is fixed, what's the workaround for setting a WOEID? I've just upgraded to Mint 17.2 and I'm now experiencing Issue 49 exactly, including 'I can't configure the applet... When I right-click the applet there is a Settings option, but that just takes me to the generic settings for all applets'. (Strangely, the weather applet worked under Mint 14, and I'm pretty sure I needed to set a WOEID for that, too; I just can't remember how. I guess it's not stored in the home directory, or it would've survived the upgrade.)

mockturtl commented 9 years ago

including 'I can't configure the applet... When I right-click the applet there is a Settings option

That option has long been replaced with Cinnamon's built-in "Configure" option.

menu

I've just upgraded to Mint 17.2 [from Mint 14]

My guess is that your applet is badly out of date. Try to remove and reinstall it (Menu -> Applets). (Failing that: delete the ~/.local/share/cinnamon/applets/weather@mockturtl folder). You'll have to re-configure your settings.

I guess it's not stored in the home directory, or it would've survived the upgrade.

I believe that's correct. Cinnamon stores this data (gsettings?); you should not expect it to survive a system upgrade.

Until this is fixed, what's the workaround for setting a WOEID?

You will need a WOEID. Try https://weather.codes/.

septhijssen commented 8 years ago

In the meantime, since the applet still does not provide feedback about invalid WOEID codes, I would like to suggest http://iannuttall.co.uk/weather-location-codes/ as possibly better alternative to lookup weather location codes. I tested codes from this list for the Netherlands and for Ireland, and all of them seem to be working. Although the list https://weather.codes/ contains a lot more codes, it seems that almost all the extra codes (the ones not on http://iannuttall.co.uk/weather-location-codes/) are invalid.

Furthermore, as long as there is no feedback for invalid WOEIDs, may I suggest a warning on the 'Get WOEID' button. Perhaps change the button text in something like 'Get WOEID (note that not every WOEID from this link is valid)'

mockturtl commented 7 years ago

Hello,

This issue is being closed because development is moving to linuxmint/cinnamon-spices/applets. Feel free to reopen your issue there.

Please see the release announcement here:

http://segfault.linuxmint.com/2017/01/changes-to-cinnamon-spices-for-developer-and-artists/