search

mockturtl / cinnamon-weather

DEPRECATED. Use linuxmint/cinnamon-spices-applets instead.
https://cinnamon-spices.linuxmint.com/applets/view/17
28 stars 35 forks source link

added option to format time to 24 hours #97

Closed niklas-heer closed 9 years ago

niklas-heer commented 9 years ago

I wanted the option to display the time for sunset and sunrise in the 24 hour format so I added that functionality and also made it a new option in the settings.

Some changes are only trailing white-spaces which my editor automatically removed.

I hope I did everything right :)

mockturtl commented 9 years ago

@niklas-heer Thanks! I can't find the ticket, but I'm sure someone requested this feature.

I think 23:59 should roll over to 00:00. Would you review?

niklas-heer commented 9 years ago

@mockturtl yes I reviewed it and indeed 23:59 rolls over to 00:00, because it would be "00:00 am". At least that is my understanding of am/pm based on http://www.mathsisfun.com/time.html, because I rarely use am/pm!

mockturtl commented 9 years ago

tracking in #98

mockturtl commented 9 years ago

@niklas-heer Great. Thanks again.