search

moclojer / clj-rq

RQ (Redis Queue) is a simple Clojure package for queueing jobs and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry
MIT License
16 stars 2 forks source link

Fault tolerant mechanisms #6

Closed J0sueTM closed 4 months ago

J0sueTM commented 4 months ago

closes #1

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough ## Walkthrough The recent changes implemented in the code introduce several features to enhance fault tolerance and flexibility in message publishing and handling. Significant additions include archiving unconsumed messages, grouping handlers by channel, and ensuring workers can resubscribe after disconnection. The modifications also involve a streamlined parameter structure for queue operations and extended pattern options in utility functions. ## Changes | Files | Change Summary | |--------------------------------------------|----------------------------------------------------------------------------------------------------| | `.../rq/pubsub.clj` | Enhanced message publishing, introduced message archiving/unarchiving, and improved worker subscription with reconnection. | | `.../rq/queue.clj` | Consolidated queue parameters into a single `options` parameter for push and pop operations. | | `.../rq/utils.clj` | Expanded `pattern->str` function to include more pattern types. | | `.../rq/pubsub_test.clj` | Refactored tests to include archiving/unarchiving and multi pub/sub functionality. | | `.../rq/utils_test.clj` | Added new tests for `pack-pattern` and `unpack-pattern` functions. | ## Assessment against linked issues | Objective (Issue #1) | Addressed | Explanation | |-----------------------------------------------------------|-----------|----------------------------------------| | Archive messages if no subscribers read them | ✅ | | | Resubscribe automatically after connection errors | ✅ | | ## Poem > In the realm of code, where messages fly, > A fault-tolerant change, reaching sky-high. > Archives keep what flew unsaid, > Workers reconnect, never misled. > Patterns and queues now refined, > A more robust system, clearly defined. > Cheers to the team, the bugs they've nixed, > Celebrating code, so gracefully fixed. ```plaintext //\_/\\ ((@v@)) ():::() - W - ```
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.