moclojer / clj-rq

RQ (Redis Queue) is a simple Clojure package for queueing jobs and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry
MIT License
15 stars 1 forks source link

Making thread blockage on `subscribe` configurable #9

Closed J0sueTM closed 2 months ago

J0sueTM commented 2 months ago

closes https://github.com/moclojer/clj-rq/issues/8

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough Recent updates to the `pubsub.clj` file introduce a new `blocking?` option to control thread blocking behavior during subscription and improve reconnection handling. Changes in `pubsub_test.clj` involve modifying a handler function to better manage state updates with a simplified argument signature. These enhancements increase flexibility and robustness in the subscription mechanism. ## Changes | File | Change Summary | |-------------------------------|------------------------------------------------------------------------------------| | `src/.../pubsub.clj` | Added `blocking?` option, refactored subscription logic for better reconnection. | | `test/.../pubsub_test.clj` | Modified handler function to take an underscore variable and update state via `swap!`. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Client participant Publisher participant Subscriber Client ->> Publisher: subscribe!(client, workers, options) alt blocking? is true Publisher -->> Subscriber: block thread else blocking? is false Publisher -->> Subscriber: non-blocking end note over Publisher, Subscriber: Improved reconnection handling logic ``` ## Poem > The rabbit hops with code refined, > Options set, blocking well-defined. > Threads now dance with nimble grace, > Reconnects handled, a robust embrace. > 🐇 In the pub/sub world so bright, > Flexibility takes flight! 🌟

Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.