search

mod-audio / mod-desktop

MOD Audio for the desktop
https://mod.audio/
GNU Affero General Public License v3.0
169 stars 9 forks source link

git submodules updated #32

Closed Samantha-uk closed 10 months ago

Samantha-uk commented 10 months ago

Updated submodules, main intent to pull in PawPaw changes to support changed linker options on newer MacOS builds.

Submodule path 'src/PawPaw': checked out '45aa5eef69da8aee1bc9385f8381107031c7655e' Submodule path 'src/mod-app-asio': checked out '34e9bd655ebaabb63bc9d182a6d0e7d0a291f7d7' Submodule path 'src/mod-ui': checked out 'c5e4f5d10cfd5d696b99ee338598948527f7f11b'

falkTX commented 10 months ago

the mod-app-asio one is wrong, points to the wrong commit. it shouldnt update anyway as it is not used on macOS. mod-ui also does not need an update yet, the change there was for something we do not use so we dont need to update it.

Samantha-uk commented 10 months ago

I think I've now reverted so just the PawPaw submodule is updated.

Samantha-uk commented 10 months ago

Ooops! I modified build.yml on my fork so I could trigger the workflow manually, I didn't realise this would get pulled into the PR; now reverted.

falkTX commented 10 months ago

PRs with CI workflows in them need to be approved manually until at least 1 PR from that author is merged. the next PRs should have CI run automatically

falkTX commented 10 months ago

I see this is fine now, thanks

Samantha-uk commented 10 months ago

Sorry it was a bit of a mess!