mod-audio / mod-host

LV2 host for Jack controllable via socket or command line
GNU General Public License v3.0
107 stars 55 forks source link

Midi clock filtered too much, slow reaction time to tempo changes #36

Open mattpepin opened 4 years ago

mattpepin commented 4 years ago

I use a Kemper Profiler guitar amp to generate the midi clock signal. However, when I switch to a different performance (bank/slot) with a different tempo, mod-host takes too long to adjust to the new tempo (it ramps up or down too slowly). I find that the filter does not react fast enough. It makes it impossible to use the midi clock for songs that change suddenly change tempo. If I use:

define AVERAGE_FILTER_STEPS 7 (instead of 47)

and completely disable the binomial filter, it works perfectly.

mattpepin commented 4 years ago

I forgot to mention that I use mod-host to drive an LV2 metronome for the whole band, so timing is crucial ;)

falkTX commented 4 years ago

The MIDI Clock sync option has a very long jitter compensation filter because of a kernel issue in the MOD Duo X, which has since been corrected. But I did not investigate if/how we can change this to a sane values, and what those values are.

How did you come up with "7", is it arbitrary?

mattpepin commented 4 years ago

Yes, it's totally arbitrary but I came up with it after some tests. In my case, it seems to work well.