search

mod-audio / mod-host

LV2 host for Jack controllable via socket or command line
GNU General Public License v3.0
108 stars 55 forks source link

mod-monitor is now running by default #52

Closed MaxPayne86 closed 2 years ago

MaxPayne86 commented 2 years ago

I'm testing hotfix-1.11 and noticed mod-monitor is now launched by main mod-host module and can no longer disabled. This could have been introduced earlier in the code, need to check.

This ends up in having mod-monitor module always between the last plugin output port and system:playback_*

In mono, this results in following jack routing

system:capture_1 -> effect_1:in -> effect_1:out -> effect_2:in -> effect_2:out -> mod-monitor:in_1 -> mod-monitor:out_1 -> system:playback_1

while on mod-ui interface right outputs are reported as Hardware Playback 1 (misleading)

I see mod-monitor implements a compressor functionality, however there are no controls on mod-ui for the parameters of this effect so I assume that is controlled by the moddevices hw hmi somehow.

I cannot find any documentation on this functionality both in mod-host and mod-ui source codes, please let me know otherwise.

[NOTE] derivative moddevices projects may prefer to not use mod-monitor/compressor

falkTX commented 2 years ago

what is the issue here?

the compressor and noisegate are not enabled on regular builds because of the lack of such controls

MaxPayne86 commented 2 years ago

hello, is source code for those builds avail? If so I was totally unaware of that, sorry. I'm working on a custom meta-moddevices yocto layer I want to publish and I'm testing build with support to hotfix-1.11. My issue is I see mod-monitor running when I execute

jack_load mod-host

where previously I had to do jack_load mod-host jack_load mod-monitor

if compressor & volume functionalitites are disabled by default then mod-monitor is a pass-thru only or it serve for functionalities I don't know?

Thx

falkTX commented 2 years ago

things have just changed for convenience. previously we needed to load mod-monitor manually, now we dont.

it is mainly there to make it easier to connect a peakmeter at the end, and to ensure we always have "output/playback" ports even if the device does not.

MaxPayne86 commented 2 years ago

Okay, it serves as a dummy playback port for the effect chain, thanks. Do you have plans for compressor/volume controls from mod-ui? Would be nice to have noise gate (input) and compressor (output) as "system-wide". It overlaps a bit with driver codecs that have such functionalitites (in input mostly) but then there would be hw deps...

falkTX commented 2 years ago

No direct plans for that atm

MaxPayne86 commented 2 years ago

Doc provided by maintainer, closing