mod-audio / mod-plugin-builder

MOD Plugin Builder
79 stars 50 forks source link

wolf-shaper not building since repositories got moved and deleted #160

Closed rominator1983 closed 1 year ago

rominator1983 commented 2 years ago

Hi @falkTX

I wanted to build the wolf-shaper plugin (watched a cool vid from https://github.com/unfa and wanted to give it a try since it seems to be available on MOD) since I am running on x86_64. But I was getting weird github authentication prompts. Turns out the URLs in plugins/package/wolf-shaper-labs/wolf-shaper-labs.mk are pointing to nirvana since the correct URL nowadays seems to be https://github.com/wolf-plugins/wolf-shaper instead of https://github.com/pdesaulniers/wolf-shaper. One gets a nice forward in a browser but obviously a prompt on the command line. Or maybe that was for the non existing .gitmodules (later on that)? Does not matter really.

I tried to make you a nice PR for the URL changes. But turns out that that's not so easy as the old commit hash d0b46c9ece642488efed3cd255df22516966b334 is now unuseable since the .gitmodules of that commit also points to several other repositories inside of https://github.com/pdesaulniers which now do neither exist in the old nor the new place.

So I tried to point everything to the newest commit hash d8dc0d0e1d3ac2bcfdff964cffdfbb143e8811c1 and thought I might run into troubles which I did. The new .gitmodules does not reference much excpept for DPF so that's fine. I tried to fiddle with the patch files that deactivate graphical stuff but finally got stuck when compiling DPF because of:

Compiling src/NanoVG.cpp (OpenGL variant)
Compiling src/pugl.cpp (OpenGL variant)
In file included from src/OpenGL.cpp:22:
src/../OpenGL.hpp:75:11: fatal error: GL/gl.h: No such file or directory
   75 | # include <GL/gl.h>
      |           ^~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:182: ../build/dgl/OpenGL.cpp.opengl.o] Error 1
make[3]: *** Waiting for unfinished jobs....

This does not make sense since I have installed libgl-dev and '/usr/include/GL/gl.h ' exists on my ubuntu box. But I do not develop c/c++ that much that I would know what is going on here with the include. And anyways it seems from the old patch files that graphical stuff should be deactivated. But in DPF it is all over the place and I would not know where to start even beginning with a clean building state.

But now I have been trying to get things to work for a at least 2 hours without success and thought I gave you my insights by creating this issue. I recon you are way faster in fixing these things than I am. If you could tell me what to change with at least some detail I might even try to implement, build and test that on my box and give you a PR.

At least now I know why that plugin is not listed in https://github.com/moddevices/mod-live-usb/blob/main/plugins/Makefile :-(

rominator1983 commented 1 year ago

Well it seems to have been fixed since it now shows up after I have upgraded my MOD to get adia-x And it even has a nice MOD GUI. Thanks