search

mod-audio / mod-plugin-builder

MOD Plugin Builder
79 stars 50 forks source link

Shiro plugins not building. Shiro plugins Labs are. dpf folder missing #176

Open rominator1983 opened 1 year ago

rominator1983 commented 1 year ago

I noticed that when doing a ./build x86_64 shiro-plugins I get an error when building shiroverb (and the other plugins in the bundle).

I looked and saw tthat the bundle shiro-plugins-labs is using the same git commit of its repository (https://github.com/ninodewit/SHIRO-Plugins.git) in plugins/package/shiro-plugins/shiro-plugins.mk So I dug further and noticed in mod-workdir that in shiro-plugins the dpf folder is missing during build while in shiro-plugins-labs it is present. When copying the folder dpf over it is sure building.

Looking at https://github.com/ninodewit/SHIRO-Plugins.git I saw that dpf is in the sub modules (https://github.com/ninodewit/SHIRO-Plugins/blob/master/.gitmodules) so there is probably some simple solution to this where during the build/bootstrap the repository does not get cloned with its sub-modules.

This has also been working some time (weeks/months?) ago since I have the modulay in a preset but found out it is missing on my pc after a new setup when using latest master-branches of everything.

I would have done a PR of course if I had gotten to the bottom of this. It shold be some simple one-line thing really I suppose.

rominator1983 commented 1 year ago

@falkTX that one should be easy. If you point me in the right direction I do a PR and hopefully learn more about the setup/bootstrap of this.