search

mod-audio / mod-plugin-builder

MOD Plugin Builder
78 stars 50 forks source link

distrho-ports-lab requires liblua5.1-0 to build #87

Open danielappelt opened 3 years ago

danielappelt commented 3 years ago

liblua5.1-0 should maybe be added to the list of dependencies in README.md.

Furthermore, the link to ttl files for TAL-Reverb-2 points to the wrong directory in lv2-data (plugins-fixed vs plugins).

falkTX commented 3 years ago

liblua5.1-0 is only needed for the premake step used in distrho-ports project. distrho-ports no longer uses premake in its latest version, it changed to meson. but we do not have host-meson package in mod-plugin-builder yet. so it is unclear for now if this will really be needed or not...

BramGiesen commented 3 years ago

@danielappelt Thanks for reporting the issue of the dangling symlink, it should be fixed now.

rominator1983 commented 1 year ago

I just tried this on my box and for sure after doing sudo apt-get install liblua5.1-0-dev the compilation of distrho-ports-lab and distrho-ports works fine. However distrho-ports-v6 needs a sudo apt-get install meson too.

I added the dependencies in https://github.com/rominator1983/completeModInstallationManual

@falkTX do you want to add that to the readme? I could provide a PR for the doc change. It wouldn't quite fit the existing block for dependencies of mod-plugin-builder itself but rather be a new block for "Some plugins need this and that". I do not like that too much myself in this repository too.

At least it's documented here.

Tal-Reverb need a shell command "premake" which I do not have (Ubuntu has premake4). The plugin seems now to reside in distrho-ports-labs package anyway. So I don't know why this should be there as a separate thing? Could this be removed since it is not building anyway?